Port "Fix bug where block_on was called from an async context" to main #7426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
talpid-wireguard/src/lib.rs line 286 at r1 (raw file):
if let Err(err) = tokio::task::spawn_blocking(move || log_tunnel_data_usage(&config, &tunnel)) .await
Wouldn't unwrapping be fine here?
Serock3
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
talpid-wireguard/src/lib.rs line 286 at r1 (raw file):
Previously, dlon (David Lönnhager) wrote…
Wouldn't unwrapping be fine here?
Probably, but I do not dare fix a panic-related bug while introducing an unwrap at this time 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply ports #7425 to the main branch 😊
This change is